fix(ktabs): allow tab anchors to be links [KHCP-13866] #2532
+141
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portikM
requested review from
adamdehaven,
jillztom,
Justineo and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
previously requested changes
Dec 2, 2024
johncowen
reviewed
Dec 2, 2024
johncowen
reviewed
Dec 2, 2024
adamdehaven
reviewed
Dec 2, 2024
adamdehaven
reviewed
Dec 2, 2024
adamdehaven
reviewed
Dec 3, 2024
docs/components/tabs.md
Outdated
Comment on lines
271
to
273
| ## Usage | ||
|
|
||
| ### Tab links |
There was a problem hiding this comment.
I'm not sure I understand the new "Usage" section here -- can we just document "Tabs as Links" under the Props instead (above the Slots section)
There was a problem hiding this comment.
Done. Made it a subheading under tabs prop since it mostly relates to that prop
There was a problem hiding this comment.
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13866
Add
toproperty inTabinterface to support rendering tabs as links